ebs/.github/pull_request_template.md
2023-12-21 08:49:38 +01:00

1.9 KiB

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Related to # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Cleanup/refactoring of an existing feature (code quality change without feature modification)
  • Improvment of an existing feature (minor tweak)
  • Documentation (no code)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Put below at least a file that was modified/added for the tests of this feature/bugfix.

  • Test A

Checklist:

  • I have assigned myself to the related ticket
  • I have read the ticket carefully and the code addresses exactly what is described in it
  • I have added tests that prove my fix is effective or that my feature works
  • Tests pass locally (make test-complete)
  • Code coverage is still at 100% (make coverage)
  • My code follows the style guidelines of this project, make ci should run without error
  • Translations have been added, I didn't put raw text in PHP files or Twig templates
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Git rebase have been made, and the PR can be merged without conflict
  • All CI checks are
  • I have removed the draft status of the PR
  • I have removed the WIP tag on the PR and also in the title
  • I have added the RFR (ready for review) tag on the PR
  • I have added the DEPLOY tag and the feature/fix can be tested on the dedicated environment
  • I have assigned someone to review the PR